Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional destination folder and get file content #7

Merged
merged 3 commits into from
May 15, 2021

Conversation

mpijierro
Copy link
Contributor

Hi,

first of all thanks for your work with this component. It saved me a lot of time.

I would like to propose two very simple changes that I hope are useful.

  1. The first is to add an optional destination folder for the downloaded files. If the folder is not specified, the operation is the original with the folder 'dropbox-temp' as the destination.

  2. The second is to add a function to get the content of a file without having to download. In this way, it is possible to treat it locally in the most convenient way.

That's all. Thanks again.
Greetings.

@dcblogdev
Copy link
Owner

thanks this looks like a nice addition, I'll look it over in more detail over the weekend.

@mpijierro
Copy link
Contributor Author

Sorry, I did a push to master with other added functionality. I have left the pull request as it was originally.

Thanks for your time

@dcblogdev dcblogdev merged commit e0d4e50 into dcblogdev:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants