Nova Flexible Content #17

dividy · 2019-12-13T15:49:47Z

Hello,

Is it compatible with Nova Flexible Content ?

I tried it and had a JS error..

Thanks !

milewski · 2019-12-14T01:34:37Z

Currently it doesn't work with flexible content

dividy · 2019-12-14T09:17:35Z

Yep, that's why i tried Nova Dependency Container but I encountered 2 issues with that package too : - The conditional field doesn't show on the detail view - Some values are overwritten by the last item of the layout I've seen you used that package too, do these issues ring a bell to you ? Thanks. Le sam. 14 déc. 2019 à 02:34, Rafael Milewski <notifications@github.com> a écrit :

…

Currently it doesn't work with flexible content — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#17?email_source=notifications&email_token=AEV5PSOYN3CPZ25FQU3FBOTQYQZ23A5CNFSM4J2O6QCKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG3WQSQ#issuecomment-565667914>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEV5PSJZRTECFPWA5OZNMJTQYQZ23ANCNFSM4J2O6QCA> .

milewski · 2019-12-14T09:48:14Z

Yeah I used that package before too but had too many issues for my use case so I built this one instead, I have seen how the Nova Dependency Container implemented support for the flexible content on this commit: epartment/nova-dependency-container@d408149 perhaps it may be very simple to port it over... I will give it a shoot, and about the 2 issues, I don't see how conditional-container would fail in there

milewski · 2019-12-16T14:31:24Z

@dividy I got it almost working and I had pushed my proof of concept to a branch called flexible field, it works on create, on update and on details view as expected, however validation is still broken :(

dividy · 2019-12-16T15:26:47Z

Wow.. This sounds like a great step forward to something functional ;-)
I'll try to have a look at this too!

dividy · 2019-12-31T11:19:11Z

Just did a composer require digital-creative/conditional-container:dev-flexible-content

Tried the package, and I'm still having an issue inside Flexible Content...

Here's the code, can you try it on your side and tell me if it works ?

Flexible::make('Produits', 'products')
            ->addLayout('Product', 'product', [
                Select::make('Type de contrat', 'type')->options([
                    'L' => 'Location',
                    'VL' => 'Vente & Location',
                    'R' => 'Relevé',
                    'V' => 'Vente',
                    'VU' => 'Vente unique',
                ])->displayUsingLabels()->rules('required'),
    
                ConditionalContainer::make([ Text::make('Prix en Location (htva)', 'price_rent') ])
                ->if('type = L'),
              
                ConditionalContainer::make([ Text::make('Prix de Vente (htva)', 'price_sale') ])
                ->if('type = V')
                ->if('type = VU'), 
    
                ConditionalContainer::make([ 
                    Text::make('Prix en Location (htva)', 'price_rent'),
                    Text::make('Prix de Vente (htva)', 'price_sale')
                ])->if('type = VL'),
    
                ConditionalContainer::make([ 
                    Text::make('Prix du Relevé (htva)', 'price_reading'),
                ])->if('type = R'),        
            ]),

dividy · 2019-12-31T11:21:30Z

On my side, it never works, and displays all the fields when I select 'R - Relevé'.. Strange ;)

bernhardh · 2020-01-11T19:48:46Z

@milewski I just used the branch as well and tried the code of @dividy but i get

TypeError: Cannot read property 'join' of undefined
    at _loop (conditional-container:175)

And I even dont see the fields.

I also tried my own, simpler example with the same result:

Flexible::make("Data")
    ->addLayout("Simple Layout", "html", [
        Select::make("Type", "type")->options([
            "html" => "HTML",
            "plain" => "Plaintext"
        ]),
        ConditionalContainer::make([
            Trix::make('Content', 'html_content')
        ])->if('type = html'),
        ConditionalContainer::make([
            Textarea::make('Content', 'plain_content')
        ])->if('type = plain')
    ])

milewski · 2020-01-12T02:46:40Z

The join issue is because the HasConditionalContainer wasn't included ... but yeah indeed there are several issues, it did work for the example I had when I was developing it but using your samples has some bugs...

milewski · 2020-01-12T03:25:52Z

@bernhardh I just fixed the issues with your example you can try again it should be working perfectly now (but without validation of course)

Form View

Detail View

milewski · 2020-01-12T03:27:17Z

@dividy your example also works now for me... I think the issue were you forgot the trait

bernhardh · 2020-01-12T10:51:01Z

Oh. So stupid. Thank you!

Now I get

Method Whitecube\NovaFlexibleContent\Flexible::resolveConditionalContainer does not exist.

The

if ($flexibleContent->isNotEmpty()) {
    $this->registerFlexibleMacros($request, $flexibleContent);
}

is false, so this macro is never added?

milewski · 2020-01-12T11:16:49Z

whats the endpoint nova is trying to hit that throws that error Method Whitecube\NovaFlexibleContent\Flexible::resolveConditionalContainer does not exist. ?

bernhardh · 2020-01-12T13:13:35Z

It occurs on edit and detail page. And the endpoint throwing it is /nova-api/MODELNAME/ID

On

vendor/laravel/framework/src/Illuminate/Support/Traits/Macroable.php:103

bernhardh · 2020-01-12T13:19:54Z

Btw. I am on dev-flexible-content 7e5e620 atm.

Ok, found it out, that if I don't use the https://github.com/eminiarts/nova-tabs package, than it works. Wrapping it into it, throws the error. The same goes with https://github.com/armincms/json package. It seems, that the FlexibleContent Element has to be on top Level?

milewski · 2020-01-12T13:40:25Z

Oh I see when you use the nova-tabs the "flexible" content is not found, so the macros are not added to it, that's why it crashes, I think it might be possible to detect, I think it is possible to add a check and see if its an instance of panel and recursively try to find flexible contents within its children

bernhardh · 2020-01-12T13:40:58Z

Ok, at least I can fix the issue with the tabs package (and all other packages based on Panel items).

In HasConditionalContainer.php:460 just add

if($field instanceof Panel && $field->data) {
    return $this->findAllFlexibleContentFields($field->data);
}

milewski · 2020-01-12T13:42:08Z

Ah ok let me add

milewski · 2020-01-12T13:47:44Z

Pushed

bernhardh · 2020-01-12T14:18:01Z

Ok, now it only worked on empty data. After save i get

Cannot bind an instance to a static closure

To fix this change HasConditionalContainer:178

$field::macro('generateFieldName', static function (array $fields) {

to

$field::macro('generateFieldName', function (array $fields = []) {

Not sure why it is decleared static in the first place? Or does this have any sideeffects?

milewski · 2020-01-13T04:18:46Z

That was a mistake, I didn't know macros wouldnt run in static context, I have removed it and pushed again

bernhardh · 2020-01-13T07:28:13Z

Thank you very much, for your help, this package (and nova-mega-filter and collapsible-resource-manager). Do you have a "buy me a cup of coffee" link or something else?

dividy · 2020-01-13T18:50:40Z

Good job guys, I watched all the action from far away, getting spammed by notifications.

I had to deliver the application to my customer, so I finally chose another working option, I used different presets instead of conditional fields. However, great work!

patrickleemsantos · 2020-04-30T16:48:21Z

@dividy Can I know what you use in order to fix this issue?

anditsung · 2020-05-19T08:04:09Z

@dividy I got it almost working and I had pushed my proof of concept to a branch called flexible field, it works on create, on update and on details view as expected, however validation is still broken :(

if ($controller instanceof CreationFieldController ||
            $controller instanceof UpdateFieldController) {

this is the part where you check the fields for creation?

i have able to make the validation work for flexible but got other issue.

Flexible::make('Produits', 'content')
                ->addLayout('Product', 'product', [
                    Select::make('Type de contrat', 'type')->options([
                        'L' => 'Location',
                        'VL' => 'Vente & Location',
                    ])->displayUsingLabels()->rules('required'),

                    ConditionalContainer::make([
                        Text::make('Prix en Location (htva)', 'price_rent')
                            ->rules('required')
                    ])
                        ->if('type = L'),

                    ConditionalContainer::make([
                        Text::make('Prix en Location (htva)', 'price_rent'),
                        Text::make('Prix de Vente (htva)', 'price_sale'),
                    ])->if('type = VL'),
                ]),

this will make all price_rent will required

https://github.com/anditsung/conditional-container/tree/flexible-content

milewski added the enhancement New feature or request label Dec 14, 2019

milewski added the help wanted Extra attention is needed label Dec 16, 2019

milewski mentioned this issue Mar 24, 2021

Use of a resource field inside Flexible layout #58

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nova Flexible Content #17

Nova Flexible Content #17

dividy commented Dec 13, 2019

milewski commented Dec 14, 2019

dividy commented Dec 14, 2019 via email

milewski commented Dec 14, 2019

milewski commented Dec 16, 2019

dividy commented Dec 16, 2019

dividy commented Dec 31, 2019 •

edited

Loading

dividy commented Dec 31, 2019

bernhardh commented Jan 11, 2020 •

edited

Loading

milewski commented Jan 12, 2020

milewski commented Jan 12, 2020

milewski commented Jan 12, 2020

bernhardh commented Jan 12, 2020 •

edited

Loading

milewski commented Jan 12, 2020

bernhardh commented Jan 12, 2020 •

edited

Loading

bernhardh commented Jan 12, 2020 •

edited

Loading

milewski commented Jan 12, 2020

bernhardh commented Jan 12, 2020 •

edited

Loading

milewski commented Jan 12, 2020

milewski commented Jan 12, 2020

bernhardh commented Jan 12, 2020

milewski commented Jan 13, 2020

bernhardh commented Jan 13, 2020

dividy commented Jan 13, 2020 •

edited

Loading

patrickleemsantos commented Apr 30, 2020

anditsung commented May 19, 2020 •

edited

Loading

Nova Flexible Content #17

Nova Flexible Content #17

Comments

dividy commented Dec 13, 2019

milewski commented Dec 14, 2019

dividy commented Dec 14, 2019 via email

milewski commented Dec 14, 2019

milewski commented Dec 16, 2019

dividy commented Dec 16, 2019

dividy commented Dec 31, 2019 • edited Loading

dividy commented Dec 31, 2019

bernhardh commented Jan 11, 2020 • edited Loading

milewski commented Jan 12, 2020

milewski commented Jan 12, 2020

Form View

Detail View

milewski commented Jan 12, 2020

bernhardh commented Jan 12, 2020 • edited Loading

milewski commented Jan 12, 2020

bernhardh commented Jan 12, 2020 • edited Loading

bernhardh commented Jan 12, 2020 • edited Loading

milewski commented Jan 12, 2020

bernhardh commented Jan 12, 2020 • edited Loading

milewski commented Jan 12, 2020

milewski commented Jan 12, 2020

bernhardh commented Jan 12, 2020

milewski commented Jan 13, 2020

bernhardh commented Jan 13, 2020

dividy commented Jan 13, 2020 • edited Loading

patrickleemsantos commented Apr 30, 2020

anditsung commented May 19, 2020 • edited Loading

dividy commented Dec 31, 2019 •

edited

Loading

bernhardh commented Jan 11, 2020 •

edited

Loading

bernhardh commented Jan 12, 2020 •

edited

Loading

bernhardh commented Jan 12, 2020 •

edited

Loading

bernhardh commented Jan 12, 2020 •

edited

Loading

bernhardh commented Jan 12, 2020 •

edited

Loading

dividy commented Jan 13, 2020 •

edited

Loading

anditsung commented May 19, 2020 •

edited

Loading