Support PHP 8.1 #25
Merged
Support PHP 8.1 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slt
force-pushed
the
php81
branch
2 times, most recently
from
0a4d021 to
3964596
Compare
PHP Fatal error: During inheritance of Iterator: Uncaught ErrorException: Return type of DCarbone\PHPConsulAPI\Values::current() should either be compatible with Iterator::current(): mixed, or the \#[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /code/vendor/dcarbone/php-consul-api/src/Values.php:104
|
I've rebased this on current master Thanks |
dcarbone
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were the changes I had to make to get my app working on PHP 8.1, around the Iterable interface
Will also require a gotime patch dcarbone/gotime#1