Fix vertical lines for ordinal charts #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charts using ordinal scales on the x axis with .renderVerticalGridLines set did not work because ordinal scales do not have a .ticks function. This patch checks for the existence of a .ticks function on the x scale before trying to use it when rendering vertical lines, and if there isn't one uses the scale's domain.
gordonwoodhull
added a commit
that referenced
this pull request
Dec 3, 2014
|
Thanks @jcamins! added a simple test and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Charts using ordinal scales on the x axis with .renderVerticalGridLines
set did not work because ordinal scales do not have a .ticks function.
This patch checks for the existence of a .ticks function on the x scale
before trying to use it when rendering vertical lines, and if there isn't
one uses the scale's domain.