Fixed error when un-brushing range chart #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the bug, but it has the side effect that the entire range is selected from the start, making it hard to select a new range. I.e. now you have to grab the handlebars at the edge of the range, rather than just dragging on the range @matthull, can you figure out how to fix this while allowing simple drag-selection on the range? |
|
ok sorry for the noise, the bug i'm referring to exists in the old version as well, it appears to come up sometimes with scrolling or changing the brush while reloading the page, or something. |
|
I'm merging this. I upgraded it to use jasmine.clock() as the other specs now do, and also to explicitly check the x domain of the chart before and after un-brushing. Thanks @matthull! |
gordonwoodhull
added a commit
that referenced
this pull request
Feb 4, 2014
gordonwoodhull
added a commit
that referenced
this pull request
Feb 4, 2014
erikdies
added a commit
to erikdies/dc.js
that referenced
this pull request
Feb 9, 2014
…ed it turns off
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #488 - when you brush the range chart, then click it to un-brush, an error occurs and focus chart fails to zoom back out.