-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composite charts should pass filters to children #706
Comments
Yes... we have the following related issues: #390 and #677. Unfortunately I haven't found the time/concentration to look closely at the problem yet. But @mtraynham reported that the obvious fix didn't work in all cases. A PR that addresses all three issues would be very much appreciated! (This is really the root issue and the others discuss some of the symptoms.) |
Also, #682 implements filter sync for row charts; I plan to generalize this approach for 2.0. (The one new feature I plan to include, because of all these bugs associated.) |
I think this was fixed a while ago but wasn't functioning correctly until #1408, released in 3.0.2 If I'm missing something, please let me know and I'll reopen. |
This is the programmatic version of #1408 and still needs to be implemented. |
Fixed by #1435 in 3.0.4 |
It seems to me that if you have a composite chart, changing filters on the parent chart should change the filters on the children. Can anyone think of a reason not to have composite charts call their children's filter functions?
The text was updated successfully, but these errors were encountered: