Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xAxisPaddingUnit default value is not 'days' #1326

Closed
a0th opened this issue Jul 26, 2017 · 2 comments
Closed

xAxisPaddingUnit default value is not 'days' #1326

a0th opened this issue Jul 26, 2017 · 2 comments

Comments

@a0th
Copy link

a0th commented Jul 26, 2017

Hey guys, not really sure where to report this, but here it goes anyway.
The documentations for both the 2.1.6 and 2.1.8 say the default xAxisPaddingUnit value is 'days'.
I dont think that is true: setting it manually to 'days' raises the error

Uncaught TypeError: d3.time[t].offset is not a function
    at Object.dc.utils.subtract (utils.js:186)
    at Object._chart.xAxisMin (stack-mixin.js:196)
    at prepareXAxis (coordinate-grid-mixin.js:459)
    at drawChart (coordinate-grid-mixin.js:1139)
    at Object._chart._doRender (coordinate-grid-mixin.js:1118)
    at Object._chart.render [as _render] (base-mixin.js:660)
    at Object.render (bar-chart.js:52)

Thats also true using 'months'. Using 'day' and 'month', however, work as intended.

@gordonwoodhull gordonwoodhull added this to the v2.0 milestone Jul 26, 2017
@gordonwoodhull
Copy link
Contributor

gordonwoodhull commented Jul 26, 2017

You're right, it's a typo in the documentation: the default is 'day' and 'month' and 'year' are valid. Will fix.

@gordonwoodhull
Copy link
Contributor

Fixed in 3.0 alpha 11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants