Remove measures from simple_manifest
#1931
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
p/update_manifests_to_remove_measures__01
branch
from
83654db to
515b505
Compare
WilliamDee
reviewed
Nov 7, 2025
| CreateProxyMeasureRule(), | ||
| FlattenSimpleMetricsWithMeasureInputsRule(), | ||
| ReplaceInputMeasuresWithSimpleMetricsTransformationRule(), | ||
| FixProxyMetricsRule(), |
Contributor
There was a problem hiding this comment.
I recently added this in to fix a bug from core's transformation. I think we would need this in here since there will be legacy manifests that still has that issue that we wouldn't want to break.
Contributor
Author
There was a problem hiding this comment.
I was using an older SHA of DSI that did not have that rule, so I thought it was removed. Added a commit to use a later version of DSI and reverted this change.
…se updated version of `dbt-semantic-interfaces`
plypaul
force-pushed
the
p/update_manifests_to_remove_measures__01
branch
from
417602c to
890037b
Compare
courtneyholcomb
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites
simple_manifestto remove measures from semantic models (via a script). In addition, the definition of simple metrics were moved to the YAML file containing the associated semantic model. Other semantic manifests will be updated in a subsequent PR.