Update offset implementation #1823
Draft
+10,207
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
courtneyholcomb
changed the title
courtneyholcomb
force-pushed
the
court/mom
branch
4 times, most recently
from
ae0fa41 to
260420d
Compare
And update snapshots
courtneyholcomb
force-pushed
the
court/mom
branch
4 times, most recently
from
90c0214 to
044fdfb
Compare
courtneyholcomb
commented
Aug 21, 2025
| @@ -0,0 +1,262 @@ | |||
| test_name: test_offset_to_grain_with_grain_matching_offset | |||
There was a problem hiding this comment.
TODO: why isn't where constraint working?
courtneyholcomb
commented
Aug 21, 2025
| @@ -0,0 +1,7678 @@ | |||
| test_name: test_offset_to_grain_with_grain_smaller_than_offset | |||
There was a problem hiding this comment.
looks right! But need where constraint to work
courtneyholcomb
commented
Aug 21, 2025
| @@ -0,0 +1,10 @@ | |||
| test_name: test_offset_window_with_grain_matching_offset | |||
There was a problem hiding this comment.
looks right, should add more test data
There was a problem hiding this comment.
this don't look right 🙃
courtneyholcomb
commented
Aug 21, 2025
| @@ -0,0 +1,20 @@ | |||
| test_name: test_offset_window_with_grain_smaller_than_offset | |||
There was a problem hiding this comment.
add more test data; this one should not look right
And update snapshots accordingly
courtneyholcomb
force-pushed
the
court/mom
branch
2 times, most recently
from
13535b8 to
abf92bf
Compare
courtneyholcomb
force-pushed
the
court/mom
branch
from
a2933e8 to
b1359dc
Compare
courtneyholcomb
force-pushed
the
court/mom
branch
from
b1359dc to
64c8654
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.