Backport updated error message for missing time spine #1707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
p__release_0.207.3_updates__02
branch
from
ba1c0d6 to
480ca1e
Compare
Merged
WilliamDee
approved these changes
Apr 1, 2025
Reverts #1428 We removed this error so that the saved query dependency resolver in mantle wouldn't hit it for a manifest that does not have any semantic models. Later, we decided not to treat that as a valid state for any MF classes, and instead to avoid instantiating the dependency resolver in that case. That means we can put this error back. Plus, [some customer ran into this error scenario](https://dbt-labs.slack.com/archives/C05K4R7KZ5Z/p1739894465024389), and they got a very unclear error instead. This will give them a better error in the future.
plypaul
force-pushed
the
p__release_0.207.3_updates__02
branch
from
480ca1e to
aa05c6f
Compare
plypaul
added a commit
that referenced
this pull request
Apr 1, 2025
This is the release PR for `0.207.3`. To avoid an unresponsive UI, the actual set of commits can be see in branch `p__release_0.207.3_updates__01` and includes the following: ``` 32: e0da921 Update `metricflow` `0.207.3.dev0` / `dbt-metricflow` to `0.8.2.dev0`. 31: d4b32fe Allow querying SCDs without `metric_time` (#1621) 30: 85c3a5e Fix off-by-one issue in pretty-formatter (#1665) 29: 3a0b5e1 Update handling for Pydantic objects in `mf_pformat` (#1666) 28: e991c5e Allow for a one-line representation in `mf_pformat_dict()` (#1667) 27: c5d7f8f Allow for lazy-evaluation of arguments in `LazyFormat` (#1669) 26: a18cc65 Remove unused class (#1674) 25: 04106d1 Fix `JoinToTimeSpineNode.with_new_parents()` (#1672) 24: 2a3f25f Add `--quiet` option to the `query` CLI command (#1680) 23: 0044633 Upgrade Jinja to fix a security vulnerability (#1684) 22: 267ea22 Add `duckdb_only` marker to CLI tests (#1689) 21: 6a0e039 Use snapshots for CLI tests (#1690) 20: a9b75ff Update tutorial project to use `ref()` (#1691) 19: f87d0ab Specify DB file path in tutorial-project profile (#1692) 18: 2544398 Allow `CliConfiguration` to be loaded from specified paths (#1693) 17: a03b8ba Remove `dbt` project metadata dependency in tutorial project generation (#1694) 16: c26e58c Avoid reinitialization of `CLIConfiguration` (#1697) 15: a3c1db9 Add process-isolated CLI runner for tests (#1695) 14: be56e43 Migrate CLI tests to use the process-isolated CLI runner (#1696) 13: b87d770 Add test case to capture display of various data types for `mf query` (#1698) 12: cf26759 Address issues with the display of numeric types (#1699) 11: 47598f9 Address display of `None` in the output of `mf query` (#1700) 10: 5a23e98 Address display of whitespace-padded strings in the output of `mf query` (#1701) 9: 781ce07 Add support for `DBT_PROFILES_DIR` / `DBT_PROJECT_DIR` in the CLI (#1702) 8: 3336aeb Update snapshots to reflect older `dbt-core` version. 7: 729c6b6 Add artifact modified time to CLI error messages (#1708) 6: 8c62e73 Use native Python methods to manage the CSV file handle (#1709) 5: 5cffe24 Configure `pytest` to skip scanning snapshots directory (#1710) 4: 1f155cd Backport updated error message for missing time spine (#1707) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR back ports an improved error message (65e2115) + adds a test for the case where the user did not configure a time spine. Previously, the user would get a cryptic error message (also see associated commit in this PR):