-
Notifications
You must be signed in to change notification settings - Fork 8
Conversation
Testing the changes here |
Formula/dbt-bigquery@1.2.0.rb
Outdated
@@ -287,7 +287,7 @@ class DbtBigqueryAT120 < Formula | |||
|
|||
def install | |||
ENV["CARGO_NET_GIT_FETCH_WITH_CLI"] = "true" | |||
venv = virtualenv_create(libexec, "python3") | |||
venv = virtualenv_create(libexec, "python3", system_site_packages: false) system_site_packages: false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a duplicate entry here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it's happening in a couple places just FYI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea I just did everything locally again, not sure what happened during find/replace
Formula/dbt-postgres@1.0.7.rb
Outdated
@@ -228,7 +228,7 @@ class DbtPostgresAT107 < Formula | |||
|
|||
def install | |||
ENV["CARGO_NET_GIT_FETCH_WITH_CLI"] = "true" | |||
venv = virtualenv_create(libexec, "python3") | |||
venv = virtualenv_create(libexec, "python3", system_site_packages: false) system_site_packages: false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same
The tests only run on the published formulas so we have to just commit these and then run the tests |
I'm ok with committing this and seeing if the fix works since we have the local testing passing |
🤔 Hrm, appears the build is still failing, though with a slightly different (albeit likely related) error. Perhaps we can add an "on failure" hook to the action to post the contents of the full error log message for us. Alternatively, we could run the brew install command w/ the verbose flag if the env is CI. The full contents of that log will be much more helpful for us than just the last 15 lines we get a sneak peek at by default. I have a few meetings this afternoon for my #dayjob, but perhaps I can tackle that this evening/weekend. |
@leahwicz - 👋 hello! I was just chatting w/ @ChenyuLInx in Slack about this since we're still seeing the GitHub Actions tests failing. I was observing some differences in behavior w/ the local Anywho - thanks for the attention to this issue! ❤️ |
resolves #160 #159
Based on suggestions from @kyleries
Description
This would stop use system site package. It will make sure install succeed but slowdown the installation.
After this change merged I see no issue install via brew locally, just the GHA is still failing
Checklist