Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use redshift_connector's get_columns call to get column metadata #899

Merged
merged 16 commits into from
Sep 10, 2024
Merged

Use redshift_connector's get_columns call to get column metadata #899

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f410771
changelog
mikealfare Aug 26, 2024
85f89d5
point to dev branches for behavior flag functionality
mikealfare Aug 26, 2024
d316b28
point to dev branches
mikealfare Aug 29, 2024
01b3fbc
register behavior flag
mikealfare Aug 29, 2024
5b3e5d9
register behavior flag
mikealfare Sep 3, 2024
c1704bf
add call to redshift get_columns behind a behavior flag
mikealfare Sep 3, 2024
5f91dcc
add tests showing different behavior when the flag is turned off and on
mikealfare Sep 4, 2024
2ccd60f
update logging event
mikealfare Sep 6, 2024
f813295
update method name to the new name in BaseAdapter
mikealfare Sep 6, 2024
fad7e35
point dbt-common back to main
mikealfare Sep 6, 2024
5598258
point dbt-core back to main
mikealfare Sep 6, 2024
babb577
point dbt-adapters back to main
mikealfare Sep 6, 2024
e2c2579
add boundary test to better understand get_columns method
mikealfare Sep 9, 2024
4b42451
Merge branch 'main' into remove-pg-catalog
mikealfare Sep 9, 2024
5689efc
update flag name
mikealfare Sep 9, 2024
142feed
update flag name in the test
mikealfare Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update method name to the new name in BaseAdapter
  • Loading branch information
@mikealfare
mikealfare committed Sep 6, 2024
commit f813295992f541cb72a9d98d6bdb9f7ea430012c
2 changes: 1 addition & 1 deletion dbt/adapters/redshift/impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class RedshiftAdapter(SQLAdapter):
)

@property
def _behavior_extra(self) -> List[BehaviorFlag]:
def _behavior_flags(self) -> List[BehaviorFlag]:
return [{"name": "retire_pg_catalog", "default": False}]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this name aligns with the naming convention: https://github.com/dbt-labs/dbt-core/blob/main/docs/guides/behavior-change-flags.md#rules-for-introducing-a-new-flag


@classmethod
Expand Down
Loading