Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore adapter MyPy issues #186

Merged
merged 2 commits into from
Sep 13, 2022
Merged

ignore adapter MyPy issues #186

merged 2 commits into from
Sep 13, 2022

Conversation

colin-rogers-dbt
Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt commented Sep 13, 2022

resolves #185

Description

Thanks to this change we are now properly inheriting typing from dbt-core resulting in mypy discovering new conflicts. Ignoring these for now and creating a new issue to investigate further at later date.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@cla-bot cla-bot bot added the cla:yes label Sep 13, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@colin-rogers-dbt colin-rogers-dbt merged commit b3ea80c into main Sep 13, 2022
@colin-rogers-dbt colin-rogers-dbt deleted the ignoreNewMyPyIssues branch September 13, 2022 22:24
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1174] mypy broken despite no code changes
2 participants