Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for column precision change #166

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

epapineau
Copy link
Contributor

@epapineau epapineau commented Aug 12, 2022

resolves #5351 (dbt-core). Test shorter columns are not considered a schema change for incremental materialization when on_schema_change = sync_all_columns

Description

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have run changie new to create a changelog entry

@cla-bot cla-bot bot added the cla:yes label Aug 12, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-redshift contributing guide.

@epapineau epapineau requested a review from ChenyuLInx August 12, 2022 22:17
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChenyuLInx ChenyuLInx merged commit fe7c6df into main Aug 12, 2022
@ChenyuLInx ChenyuLInx deleted the tests/incremental-column-precision-changes branch August 12, 2022 22:33
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
* add test for column precision change

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants