Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init push for adding changie to redshift #152

Merged
merged 4 commits into from
Aug 10, 2022
Merged

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Aug 8, 2022

resolves #151

Description

Adding changie to all adapter repos to match parity with dbt-core.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-redshift next" section.

@McKnight-42 McKnight-42 self-assigned this Aug 8, 2022
@cla-bot cla-bot bot added the cla:yes label Aug 8, 2022
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny format issue. Then good to go!

Comment on lines +58 to +60
### Contributors
{{- range $k,$v := $contributorDict }}
- [@{{$k}}](https://github.com/{{$k}}) ({{ range $index, $element := $v }}{{if $index}}, {{end}}[#{{$element}}](https://github.com/dbt-labs/dbt-redshift/pull/{{$element}}){{end}})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Contributors
{{- range $k,$v := $contributorDict }}
- [@{{$k}}](https://github.com/{{$k}}) ({{ range $index, $element := $v }}{{if $index}}, {{end}}[#{{$element}}](https://github.com/dbt-labs/dbt-redshift/pull/{{$element}}){{end}})
### Contributors
{{- range $k,$v := $contributorDict }}
- [@{{$k}}](https://github.com/{{$k}}) ({{ range $index, $element := $v }}{{if $index}}, {{end}}[#{{$element}}](https://github.com/dbt-labs/dbt-redshift/pull/{{$element}}){{end}})

Can't have these spaces. They carry over.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

believe that should be fixed now.

@McKnight-42 McKnight-42 merged commit 26cf1cc into main Aug 10, 2022
@McKnight-42 McKnight-42 deleted the mcknight-ct-1011 branch August 10, 2022 15:32
@McKnight-42 McKnight-42 mentioned this pull request Aug 10, 2022
4 tasks
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
* init push for adding changie to redshift

* add changelog and run pre-commit

* change ref for no issue to dbt-labs#150 and add condtional logic for kinds dependency and security

* try to fix spacing issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1011] Add changie to dbt-redshift
2 participants