snowflake delta format #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
It would be great if this PR is completed @jeremyyeo because at this moment external tables in delta can't be created using the package. |
dataders
reviewed
Apr 4, 2024
Comment on lines
-9
to
+10
| {% set manual_refresh = (partitions and not auto_refresh) %} | ||
| {% set manual_refresh = not auto_refresh %} |
There was a problem hiding this comment.
@danielefrigo explain why partitions is removed here
There was a problem hiding this comment.
With this condition, only partitioned tables are refreshed by the package.
There are multiple situations (delta tables is one of them) in which you want to manually refresh an external tables (e.g. you cannot setup Snowflake automatic refresh for technical reasons on the cloud provider), so I'd prefer to link this feature only to the auto_refresh flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
resolves: #198
Snowflake supports external tables on Delta format external stages, but they do not support automatic refresh.
When creating them, it's mandatory to specify
refresh_on_create = false.Checklist