Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
This PR adds support for Trino (using the Hive connector).
I have tested things on my local setup and tried my best to add relevant configuration for integration tests (I copied a lot from #133).
For the integration tests to work, there should be an S3 bucket called
test_bucket
, a Trino instance configured with the Hive connector and access to said S3 bucket (see docs). I excluded JSON tests as I have little experience with Hive external JSON tables.The following environment variables should be set to be able access Trino in CI:
TRINO_TEST_USER
TRINO_TEST_PASSWORD
TRINO_TEST_HOST
TRINO_TEST_PORT
TRINO_TEST_DBNAME
I will gladly assist any effort to get the integration tests running and improve this plugin.
Checklist