Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snowflake delta support #138

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Snowflake delta support #138

merged 2 commits into from
Sep 21, 2022

Conversation

aPeterHeise
Copy link
Contributor

Description & motivation

Added support for delta lake as described in #137

@aPeterHeise
Update create_external_table.sql
7db8a17 
Added table_format option to be used with Delta.
@aPeterHeise
Added documentation for Delta lake
cf89403 
Added documentation for Delta lake
@aPeterHeise
Copy link
Contributor Author

See here for feature description.

@aPeterHeise
Copy link
Contributor Author

Hi @jtcohen6 , how can I convince you to accept this PR? ;-)

@sdrzymala
Copy link

Hi @jtcohen6 ,
There is more people and teams actually waiting for that PR. Any particular reason why it shouldn't be closed? Anyhow thanks a lot for your time! And big kudos to @aPeterHeise !

@pgoslatara
Copy link
Contributor

@jtcohen6 Can this PR get some love please? Currently using this fix at a client so would be great to get it onto main.

@jeremyyeo
Copy link
Collaborator

Hey @aPeterHeise, thanks for the contribution - sorry for the delay here.

Just looking over this and looks straight forward and the docs here seem to suggest that AUTO_REFRESH needs to be FALSE when table format is delta?

Jerco tested this out and found that indeed that Snowflake does raise an error if we have a wrong combination:

"SQL compilation error: invalid property combination 'AUTO_REFRESH'='true' and 'TABLE_FORMAT'='delta'"

We don't have a way to test this in CI right now but this change looks good.

@jeremyyeo jeremyyeo merged commit 223ded7 into dbt-labs:main Sep 21, 2022
This was referenced Oct 31, 2022
Open
Closed
@zvijayakumar zvijayakumar mentioned this pull request Nov 11, 2023
Open
@amirbtb amirbtb mentioned this pull request Feb 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aPeterHeise @sdrzymala @pgoslatara @jeremyyeo