Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add semantic models #444

Merged
merged 4 commits into from
Aug 9, 2023
Merged

add semantic models #444

merged 4 commits into from
Aug 9, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Aug 7, 2023

resolves #431

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop
Copy link
Member Author

emmyoop commented Aug 7, 2023

Metrics Page - depends on a semantic model
Screenshot 2023-08-07 at 3 28 23 PM

Semantic Model Page with new Project nav on left
Screenshot 2023-08-07 at 3 26 34 PM

condensed DAG model -> semantic model -> metric
Screenshot 2023-08-07 at 3 26 46 PM

full screen view of above
Screenshot 2023-08-07 at 3 27 05 PM

@emmyoop
Copy link
Member Author

emmyoop commented Aug 7, 2023

A few observations:

  1. semantic models don't have labels so there is no "friendly name" to display. Used node.name instead.

Open Questions

  1. Is there some kind of code to display? Metrics used to display the generated sql but dbt docs is failing on that. Wasn't sure if it's not possible or if I missed something.
  2. Would you prefer a different color for semantic models?
  3. Should other fields be displayed for semantic models? The above is a copy of the metric node page.

@emmyoop
Copy link
Member Author

emmyoop commented Aug 8, 2023

Added entities
Screenshot 2023-08-08 at 10 58 41 AM

@emmyoop emmyoop requested a review from QMalcolm August 8, 2023 16:00
@emmyoop emmyoop marked this pull request as ready for review August 8, 2023 16:00
@emmyoop emmyoop requested a review from aranke August 8, 2023 18:13
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the most familiar with this codebase, but at a glance LGTM!

@emmyoop emmyoop merged commit af820a3 into main Aug 9, 2023
6 checks passed
@emmyoop emmyoop deleted the er/semestic-models-metrics branch August 9, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2740] Ensure semantic models & metrics are included in DAG viz
2 participants