Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace typing.Dict with dict #8516

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

mikealfare
Copy link
Contributor

resolves #
docs dbt-labs/docs.getdbt.com/#

Problem

It appears that we're sub-classing a type and using that in place of a class.

Solution

Replace the super class with the actual class (dict).

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Aug 29, 2023
@cla-bot cla-bot bot added the cla:yes label Aug 29, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% ⚠️

Comparison is base (07372db) 86.34% compared to head (82d5f1d) 86.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8516      +/-   ##
==========================================
- Coverage   86.34%   86.32%   -0.03%     
==========================================
  Files         174      174              
  Lines       25579    25579              
==========================================
- Hits        22087    22080       -7     
- Misses       3492     3499       +7     
Flag Coverage Δ
integration 83.10% <100.00%> (-0.03%) ⬇️
unit 65.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
core/dbt/adapters/base/relation.py 93.63% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant