Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ct 738/dbt debug log fix #6541

Merged
merged 18 commits into from
Jan 21, 2023
Merged

Ct 738/dbt debug log fix #6541

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9085458
Code cleanup and adding stderr to capture dbt
VersusFacit Jan 7, 2023
10f8b93
Debug with --log-format json now prints structured logs.
VersusFacit Jan 7, 2023
17fecdc
Add changelog.
VersusFacit Jan 7, 2023
d1a420a
Move logs into miscellaneous and add values to test.
VersusFacit Jan 7, 2023
39c3c36
nix whitespace and fix log levels
VersusFacit Jan 7, 2023
65a01e1
List will now do structured logging when log format set to json.
VersusFacit Jan 8, 2023
3505aae
Add a quick None check.
VersusFacit Jan 8, 2023
ec6c9dd
Add a get guard to class check.
VersusFacit Jan 8, 2023
ee24e04
Better null checking
VersusFacit Jan 8, 2023
de12d64
The boolean doesn't reflect the original logic but a try-catch does.
VersusFacit Jan 8, 2023
a3aca7e
Merge main. Resolve conflicts.
VersusFacit Jan 19, 2023
c8e03eb
Address some code review comments and get us working again.
VersusFacit Jan 20, 2023
f0c5f5b
Simplify logic now that we have a namespace object for self.config.args.
VersusFacit Jan 20, 2023
57549eb
Simplify logic for json log format checking.
VersusFacit Jan 20, 2023
7a5b642
Simplify code for allowing our GraphTest cases to pass while also hid…
VersusFacit Jan 20, 2023
befddb3
Simplify structured logging types.
VersusFacit Jan 20, 2023
96a48cb
Fix up boolean logic and simplify via De'Morgan.
VersusFacit Jan 20, 2023
8862696
Nix unneeded fixture.
VersusFacit Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge main. Resolve conflicts.
  • Loading branch information
@VersusFacit
VersusFacit committed Jan 19, 2023
commit a3aca7e8c4c06d0ed927839fc0d3a6ab06a5228b
2 changes: 1 addition & 1 deletion core/dbt/task/list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
NoNodesSelected,
ListRunDetails,
)
from dbt.exceptions import RuntimeException, InternalException
from dbt.exceptions import DbtRuntimeError, DbtInternalError


class ListTask(GraphRunnableTask):
Expand Down
28 changes: 14 additions & 14 deletions tests/unit/test_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,21 +383,21 @@ def test_event_codes(self):
FlushEventsFailure(),
TrackingInitializeFailure(),
RunResultWarningMessage(),
# TODO fix these
DebugEnvironmentDetails(msg=""),
DebugDependenciesDetails(msg=""),
DebugDependenciesSuccess(msg=""),
DebugDependenciesFailure(msg=""),
DebugConfigurationDetails(msg=""),
DebugConfigurationSuccess(msg=""),
DebugConfigurationFailure(msg=""),
DebugConnectionDetails(msg=""),
DebugConnectionSuccess(msg=""),
DebugConnectionFailure(msg=""),
DebugRunSuccess(msg=""),
DebugRunFailure(msg=""),
DebugMiscMessages(msg=""),
ListRunDetails(msg=""),

# DebugDependenciesDetails(msg=""),
# DebugDependenciesSuccess(msg=""),
# DebugDependenciesFailure(msg=""),
# DebugConfigurationDetails(msg=""),
# DebugConfigurationSuccess(msg=""),
# DebugConfigurationFailure(msg=""),
# DebugConnectionDetails(msg=""),
# DebugConnectionSuccess(msg=""),
# DebugConnectionFailure(msg=""),
# DebugRunSuccess(msg=""),
# DebugRunFailure(msg=""),
# DebugMiscMessages(msg=""),
# ListRunDetails(msg=""),
# T - tests ======================
IntegrationTestInfo(),
IntegrationTestDebug(),
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.