Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping version to 1.4.0a1 and generate changelog #5965

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@github-actions github-actions bot requested a review from a team as a code owner September 28, 2022 18:22
@github-actions github-actions bot requested a review from a team September 28, 2022 18:22
@github-actions github-actions bot requested a review from a team as a code owner September 28, 2022 18:22
@github-actions github-actions bot added the Skip Changelog Skips GHA to check for changelog file label Sep 28, 2022
@cla-bot cla-bot bot added the cla:yes label Sep 28, 2022
Comment on lines 1 to 6
## dbt-core 1.4.0-a1 - September 28, 2022

### Breaking Changes

- Renaming Metric Spec Attributes ([#5774](https://github.com/dbt-labs/dbt-core/issues/5774), [#5775](https://github.com/dbt-labs/dbt-core/pull/5775))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all of these changes belong in 1.3 and not here. Related issue: #5074

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmyoop I updated this to look like what we did last time. I think this look right but would you take another look to double check please?

@leahwicz leahwicz closed this Sep 29, 2022
@leahwicz leahwicz reopened this Sep 29, 2022
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Looks good now!

@leahwicz leahwicz merged commit c2ab297 into main Sep 29, 2022
@leahwicz leahwicz deleted the prep-release/1.4.0a1_3145906121 branch September 29, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants