Put black config in explicit config

[max-sixty]

This lets editors etc use the correct config

resolves #5946

Description

Checklist

• I have read the contributing guide and understand what's expected of me
• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
• I have run changie new to create a changelog entry

[iknox-fa]

Hi @max-sixty!
Thanks for opening this PR, however merging it would break our pre-commit hooks which we rely on for:

• local development Makefile targets
• checking our code in the release process
• cleaning up the PR from our version bump setup

Additionally adding a pyproject.toml has a lot of implications for packaging that we haven't explored (although we have a ticket in the queue to do so at some point)

Can you say a bit more about what you're trying to achieve here? If all you want is to use black in your IDE instead of as a pre-commit hook, may I suggest just configuring black directly in your IDE (VSCode / Pycharm))?

[iknox-fa]

Needs further discussion
See: #5947 (comment)

[max-sixty]

however merging it would break our pre-commit hooks which we rely on for:

I don't think that's the case, respectfully. In the existing code, pre-commit passes configs to black. In the proposed code, black already has the configs. So pre-commit is running with exactly the same configs in both cases. Note that the pre-commit tests pass; and feel free to have a go locally.

This is the standard approach for using static tools with pre-commit, e.g. we've done this in https://github.com/pydata/xarray for years.

Can you say a bit more about what you're trying to achieve here? If all you want is to use black in your IDE instead of as a pre-commit hook, may I suggest just configuring black directly in your IDE (VSCode / Pycharm))?

Right, but with the proposed approach, it avoids everyone having to add a repo-specific configuration themselves. It's friendlier to new contributors!

---

Though I don't have a religious belief here. I noticed it when doing development on the repo, and thought it would be helpful to make it conform to best practice. But if the whole team has an aesthetic view against it, I would not be offended!

[iknox-fa]

My mistake @max-sixty -- I misremembered the process isolation pre-commit uses when running hooks as isolating them from non pre-commit-config.yaml config values. Let's give it a whirl.

[iknox-fa]

LGTM

[max-sixty]

Cheers @iknox-fa ! Appreciate your openness