Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated docker readme CT-452 #5018

Merged
merged 2 commits into from
Apr 8, 2022
Merged

updated docker readme CT-452 #5018

merged 2 commits into from
Apr 8, 2022

Conversation

iknox-fa
Copy link
Contributor

@iknox-fa iknox-fa commented Apr 8, 2022

resolves # 4990

Description

Updates docs to reflect the necessity of using buildkit with our dockerfile

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

@cla-bot cla-bot bot added the cla:yes label Apr 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@iknox-fa iknox-fa changed the title updated docker readme updated docker readme CT-452 Apr 8, 2022
@iknox-fa iknox-fa marked this pull request as ready for review April 8, 2022 19:20
@iknox-fa iknox-fa requested a review from a team as a code owner April 8, 2022 19:20
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iknox-fa iknox-fa merged commit 2b3fb7a into main Apr 8, 2022
@iknox-fa iknox-fa deleted the iknox-update-docker-docs branch April 8, 2022 19:30
VersusFacit pushed a commit that referenced this pull request Apr 14, 2022
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants