Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the only target
type
option was"redshift"
. Now, thistype
field can be set to"postgres"
instead. Everything works almost exactly the same, but this differentiation is used for injecting variables into the compilation context.In this branch, one new context variable is added,
sql_now
. In Redshift, this expands togetdate()
and in Postgres, it expands toclock_timestamp()
. Whilenow()
is more canonical (I think?),now()
reflects the time of the start of the transaction, whereasclock_timestamp() reflects the wall-clock time when the statement is executed. The primary use case for
sql_now` is for pre-and-post-hook audit records, we definitely want wall-clock time.An example of
sql_where
(and macros):Which compiles to:
In sum, this is a pretty minor change, but it has pretty big ramifications for how we think about packages. Curious to hear your thoughts, @jthandy