Improve --add-package duplicate detection #12239
Open
+166
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
After fixing the core bug in #9104, the check_for_duplicate_packages method still had limitations in its duplicate detection logic:
These issues made it difficult to reliably detect and remove duplicate packages when using
dbt deps --add-package, potentially leading to packages being listed multiple times inpackages.yml.Solution
Flexible Variant Matching
Word Boundary Checking
Enhanced Docstring
Note this branched off #12233 and is dependent on those changes. But I separated it out since it's a different fix
Checklist