Use xdg

[dradetsky]

Resolves #2515

Problem

We hardcode the profile dir to ~/.dbt instead of using xdg.

On a related note, there was a circular dep issue that caused us to have to copypaste default_profiles_dir() instead of just importing it (which is annoying if we want to add more complexity to it), so we have to fix that.

Solution

Import & use appdirs.

Considerations

Per #2515, this has different effects on different platforms. I'm only thinking about it in terms of Linux, but maybe we don't want to use this on win/macos. Somebody else more familiar with those should comment.

Checklist

• I have read the contributing guide and understand what's expected of me.
• I have run this code in development, and it appears to resolve the stated issue.
• This PR includes tests, or tests are not required or relevant for this PR.
• This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
• This PR includes type annotations for new and modified functions.

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @dradetsky

[github-actions]

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

[dradetsky]

Fun Fact: pre-commit didn't work for me locally; most things were fine, but flake8 broke with

AttributeError: 'EntryPoints' object has no attribute 'get'

Looking into this error, the flake8 team just replies "use the new version". The project uses 4.0.1, and flake8 is on 7.1.1. It might be time to upgrade.

Additional Consideration: do we need to auto-migrate configs from ~/.dbt to ~/.config/dbt?

[dradetsky]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[dradetsky]

Whether this needs tests seems like something Product/DX can answer while they're approving it (or I guess rejecting it) so I'm ignoring that for the moment.

[dbeatty10]

@dradetsky re-assessing this as a feature request beginning here: #2515 (comment)