Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #62

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Update README.md #62

merged 1 commit into from
Jan 17, 2023

Conversation

lbenezra-FA
Copy link
Contributor

Description & motivation

The advanced cloud usage section for the compare-column-values was incorrect, and needed more code / explanation for it to work properly.

Checklist

  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)

@lbenezra-FA lbenezra-FA requested a review from joellabes January 17, 2023 18:21
@joellabes
Copy link
Contributor

Do you think we should instead ship a print_results_cloud() macro that takes audit_results as input? so it would basically be:

Core

{% set audit_results = run_query(audit_query) %}

{% if execute %}
{% do audit_results.print_table() %}
{% endif %}

Cloud

{% set audit_results = run_query(audit_query) %}

{% if execute %}
{% audit_helper.print_results_cloud(audit_results) %}
{% endif %}

This feels nicer than making people create the macro themselves, wdyt?

@lbenezra-FA
Copy link
Contributor Author

@joellabes YES!!! love. that would be epic.

@lbenezra-FA
Copy link
Contributor Author

Can we merge this working option in the meantime?

@joellabes
Copy link
Contributor

Yeah this is just a readme change so let's do it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants