Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compare_queries macro #4

Merged
merged 3 commits into from
Jul 3, 2019
Merged

Add compare_queries macro #4

merged 3 commits into from
Jul 3, 2019

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Jul 1, 2019 •
edited
Loading

I created the compare_queries macro, and then updated the compare_relations macro to use the SQL from the compare_queries macro, to reduce duplication.

@clrcrl clrcrl force-pushed the feature/compare-queries branch from 54c1cc7 to da6b986 Compare July 1, 2019 19:16
@clrcrl clrcrl requested a review from drewbanin July 3, 2019 15:39
@clrcrl clrcrl force-pushed the feature/compare-queries branch from 4461b9d to 85848f1 Compare July 3, 2019 16:13
drewbanin
drewbanin approved these changes Jul 3, 2019
View reviewed changes
Copy link

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Really cool how you abstracted this out to work on queries too. Ship it :)

@clrcrl clrcrl merged commit f2e45a5 into master Jul 3, 2019
@joellabes joellabes deleted the feature/compare-queries branch February 14, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clrcrl @drewbanin