Skip to content

Conversation

@nishan-soni
Copy link

resolves #1467

Problem

This PR adds a warning when underscores (_) in the Snowflake account field are automatically replaced with hyphens (-) to form a valid account URL. Previously, this normalization happened silently, which could make debugging connection failures difficult.

Solution

Emit an AdapterEventWarning if any underscores in the account name were substituted.

Testing

Manual tests to confirm the warning was logged.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@nishan-soni nishan-soni requested a review from a team as a code owner November 23, 2025 23:54
@cla-bot cla-bot bot added the cla:yes The PR author has signed the CLA label Nov 23, 2025
@colin-rogers-dbt
Copy link
Contributor

colin-rogers-dbt commented Dec 2, 2025

If someone has set their project to error on warnings we could cause their project to unexpectedly fail. If the purpose is to make it easier to debug could we just emit a debug log instead?

@nishan-soni
Copy link
Author

If someone has set their project to error on warnings we could cause their project to unexpectedly fail. If the purpose is to make it easier to debug could we just emit a debug log instead?

I can switch this to a debug log 👍

@colin-rogers-dbt
Copy link
Contributor

Thanks, appreciate the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes The PR author has signed the CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Add warning when Snowflake account names with underscores are automatically normalized to hyphens

2 participants