Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBOS Cloud login support #5

Merged
merged 3 commits into from
Feb 25, 2024
Merged

DBOS Cloud login support #5

merged 3 commits into from
Feb 25, 2024

Conversation

devhawk
Copy link
Collaborator

@devhawk devhawk commented Feb 23, 2024

No description provided.

src/configuration.ts Outdated Show resolved Hide resolved
src/configuration.ts Outdated Show resolved Hide resolved
Copy link
Member

@qianl15 qianl15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest preview version of the SDK eliminates -u userName option in the login command. We can make the change later in this extension (sorry the CLI is still changing rapidly). Otherwise, this PR looks good!

Copy link
Member

@qianl15 qianl15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's merge this PR :)

@devhawk devhawk merged commit e742ddb into main Feb 25, 2024
2 checks passed
@devhawk devhawk deleted the devhawk/login branch February 25, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants