Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

look for launch config with npx dbos debug OR npx dbos-sdk debug #37

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

devhawk
Copy link
Collaborator

@devhawk devhawk commented Jun 18, 2024

When launching the TT debugger, we look for an existing launch configuration containing npx dbos debug. However, DBOS also supports useing the dbos-sdk cli command. So this PR updates the extension to look use the first launch configuration with either npx dbos debug or npx dbos-sdk debug in the command

Copy link
Member

@apoliakov apoliakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me (not sure if others need to take a look?)
Thanks Harry!

Copy link
Member

@qianl15 qianl15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch -- I think it's good to have backward compatibility.

@devhawk devhawk merged commit 4e0694f into release/v1.3 Jun 18, 2024
2 checks passed
@devhawk devhawk deleted the devhawk/dbos-sdk-fix branch June 18, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants