WFQ Tests & Utilities #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraftp
approved these changes
Oct 8, 2024
qianl15
reviewed
Oct 9, 2024
| @@ -676,6 +677,7 @@ export class DBOSExecutor implements DBOSExecutorContext { | |||
| ) { | |||
| // TODO: Make this transactional (and with the queue step below) | |||
| args = await this.systemDatabase.initWorkflowStatus(internalStatus, args); | |||
| await debugTriggerPoint(DEBUG_TRIGGER_WORKFLOW_ENQUEUE); | |||
There was a problem hiding this comment.
I wonder if this will add overhead to non-debug production workloads? If so, can we disable this in prod?
There was a problem hiding this comment.
Would be extremely surprised if the overhead is measurable.
There was a problem hiding this comment.
In this case, where it is against several database updates, I agree. However, disabling in prod is not a bad idea.
There was a problem hiding this comment.
We could get it down to a boolean check pretty easily. But we can do it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move queue check code into system DB
A way to intercept code at various places during test and recreate scenarios that may depend on timing holes.