queue filter in sql #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdml
commented
Aug 28, 2025
| } | ||
| } | ||
|
|
||
| req.Status = "" // We are not expecting a filter here but clear just in case |
There was a problem hiding this comment.
Because the console never passes a status, I previously just dismissed any status filter received on the queues endpoint. I think this is wrong, so this PR only sets enqueued/pending if no status is present in the request.
kraftp
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new option to ListWorkflows to filter for "queues only".
Note that this implements our defaults: when queues only is requested, we only return
PENDINGandENQUEUEDworkflows. But this implementation will respect any provided filter, for maximum flexibility. (You can query allSUCCESStasks across all queues.)