Executor config: app version/ executor ID #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maxdml
commented
Aug 27, 2025
maxdml
commented
- allow user provided executor ID, app version
- make update wf outcome idempotent if status transitions from cancel to error
…ome idempotent if status transitions from cancel to error
maxdml
commented
Aug 27, 2025
| recordedResult, err := s.checkOperationExecution(ctx, checkInput) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to check operation execution: %w", err) | ||
| return nil, err |
There was a problem hiding this comment.
This seemingly innocuous change will be dug deeper in a future PR: the end-user should receive, when appropriate, a DBOSError, rather than a normal error wrapping the DBOSError. Will need polish.
kraftp
approved these changes
Aug 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.