actually check DLQ #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me order but might complete out of order.
maxdml
commented
Aug 18, 2025
|
|
||
| - name: Run tests | ||
| run: go vet ./... && gotestsum --format github-action -- -race ./... | ||
| run: go vet ./... && gotestsum --format github-action -- -race -v -count=1 ./... |
There was a problem hiding this comment.
This disables "caching" for the tests...
maxdml
commented
Aug 18, 2025
Comment on lines
+227
to
+245
| assert.Equal(t, WorkflowStatusPending, status.Status, "expected workflow to be in PENDING status after recovery") | ||
| } | ||
|
|
||
| dlqHandle, err := recoverPendingWorkflows(dbosCtx.(*dbosContext), []string{"local"}) | ||
| require.NoError(t, err, "failed to recover pending workflows") | ||
| assert.Len(t, dlqHandle, 1, "expected 1 handle in DLQ") | ||
| retries := 0 | ||
| for { | ||
| dlqStatus, err := dlqHandle[0].GetStatus() | ||
| require.NoError(t, err, "failed to get status of DLQ workflow handle") | ||
| if dlqStatus.Status != WorkflowStatusRetriesExceeded && retries < 10 { | ||
| time.Sleep(1 * time.Second) // Wait a bit before checking again | ||
| retries++ | ||
| continue | ||
| } | ||
| require.NoError(t, err, "failed to get status of DLQ workflow handle") | ||
| assert.Equal(t, WorkflowStatusRetriesExceeded, dlqStatus.Status, "expected workflow to be in DLQ after max retries exceeded") | ||
| handles = append(handles, dlqHandle[0]) | ||
| break |
There was a problem hiding this comment.
we were not actually testing the DLQ behavior in this test -- now we do
maxdml
commented
Aug 18, 2025
| }() | ||
|
|
||
| typedHandle := newWorkflowHandle[R](handle.dbosContext, handle.workflowID, typedOutcomeChan) | ||
| typedHandle := newWorkflowHandle(handle.dbosContext, handle.workflowID, typedOutcomeChan) |
There was a problem hiding this comment.
not necessary because inferred from typedOutcomeChan
kraftp
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
created_attimestamps. When this happens it can cause unexpected priority queuing behavior. Ideally we'd have microseconds granularity.