Skip to content

Conversation

vr-varad
Copy link
Contributor

@vr-varad vr-varad commented Sep 10, 2025

Fixes #87

@vr-varad
Copy link
Contributor Author

@maxdml Kindly review at your convenience.

@maxdml
Copy link
Collaborator

maxdml commented Sep 10, 2025

@vr-varad thank you for your contributions! Two main comments:

  • The custom pgxpool should be provided by the end-user, as a new argument to the Config of DBOSContext. I didn't describe Accept custom pgxpool #87 well enough, sorry about that. We'll pass the user-provided through to newSystemDatabase, as you are doing now.
  • We need to tests that the custom pool works. For this we can add a new test in dbos_test.go (e.g., TestCustomSysDBPool) that will create a new DBOSContext with a custom pgx pool, then do something simple, like running a workflow with a step. You can look at workflows_test.go to see how its done.

@vr-varad
Copy link
Contributor Author

@maxdml Made the required changes, kindly review.

Copy link
Collaborator

@maxdml maxdml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vr-varad , left a few comments. We're getting there!

@vr-varad
Copy link
Contributor Author

Hey @maxdml made the changes accordingly!!!

@vr-varad vr-varad requested a review from maxdml September 12, 2025 14:40
@vr-varad
Copy link
Contributor Author

Done!! @maxdml
and test passed as well!!!
image

@vr-varad
Copy link
Contributor Author

Any Update on this @maxdml

@vr-varad vr-varad requested a review from maxdml September 16, 2025 08:30
Copy link
Collaborator

@maxdml maxdml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @vr-varad

@maxdml maxdml merged commit fc9aa09 into dbos-inc:main Sep 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept custom pgxpool

2 participants