-
Notifications
You must be signed in to change notification settings - Fork 38
Fix: Accept custom pgxpool #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@maxdml Kindly review at your convenience. |
@vr-varad thank you for your contributions! Two main comments:
|
@maxdml Made the required changes, kindly review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vr-varad , left a few comments. We're getting there!
Hey @maxdml made the changes accordingly!!! |
Done!! @maxdml |
Any Update on this @maxdml |
2d6bf25
to
a0d7403
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks @vr-varad
Fixes #87