Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fui: Add support for .mm files. #24

Merged
merged 1 commit into from
Aug 15, 2017
Merged

Fui: Add support for .mm files. #24

merged 1 commit into from
Aug 15, 2017

Conversation

Shachlan
Copy link
Collaborator

Files that are imported within .mm files will not be marked as unused.

dblock
dblock requested changes Aug 14, 2017
View reviewed changes
Copy link
Owner

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some changelog changes, everything else looks good.

CHANGELOG.md Outdated

* Your contribution here.

### 0.4.1 (8/13/2017)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We haven't released 0.4.1, so please undo this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

CHANGELOG.md Outdated

* Your contribution here.

### 0.4.1 (8/13/2017)

* Support .mm files.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Match the format of other changelog lines, with your name & al.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@Shachlan
Copy link
Collaborator Author

Finished fixing changelog.

dblock
dblock reviewed Aug 14, 2017
View reviewed changes
CHANGELOG.md Outdated
@@ -1,6 +1,6 @@
### 0.4.1 (Next)

* Your contribution here.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please put this one back for the next contributor?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@Shachlan
Fui: Add support for .mm files.
4604ff2 
Files that are imported within .mm files will not be marked as unused.
@Shachlan
Copy link
Collaborator Author

Finished round.

@dblock dblock merged commit 933a40a into dblock:master Aug 15, 2017
@dblock
Copy link
Owner

dblock commented Aug 15, 2017

Thanks @Shachlan. Want to help out with this project, maybe do the next release?

@Shachlan Shachlan deleted the feature/mm-files branch August 16, 2017 05:38
@Shachlan
Copy link
Collaborator Author

You mean, do the same process as in 33e2a48 and 9626cda? No problem.

@dblock
Copy link
Owner

dblock commented Aug 16, 2017

I opened #25 for you @Shachlan, thanks!

You should PR a RELEASING.md like this one: https://github.com/dblock/ruby-enum/blob/master/RELEASING.md, for the next person.

What's your Rubygems email for access?

@Shachlan
Copy link
Collaborator Author

nihohit at gmail

@Shachlan
Copy link
Collaborator Author

Also, what's Travis CI? How do I send a build to it?

@dblock
Copy link
Owner

dblock commented Aug 16, 2017 •
edited
Loading

Travis is https://travis-ci.org/, automatically runs builds (tests) for master and pull requests.

https://travis-ci.org/dblock/fui

So you don't need to send anything to it manually.

@Shachlan Shachlan mentioned this pull request Aug 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shachlan @dblock