feat: Implement testparameter endpoints #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewuerger
requested changes
May 22, 2025
Collaborator
ewuerger
left a comment
ewuerger
left a comment
There was a problem hiding this comment.
Didn't mean to find so many things. After resolving them I would write:
LGTM.
Comment on lines
193
to
203
| assert len(items) == 1 | ||
| assert isinstance( | ||
| items[0].scope, dm.TestRecord | ||
| ), "For parameters of TestRecords the scope must be a TestRecord" | ||
| response = delete_test_record_test_parameter.sync_detailed( | ||
| self._project_id, | ||
| items[0].scope.test_run_id, | ||
| items[0].scope.work_item_project_id, | ||
| items[0].scope.work_item_id, | ||
| str(items[0].scope.iteration), | ||
| items[0].name, |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert len(items) == 1 | |
| assert isinstance( | |
| items[0].scope, dm.TestRecord | |
| ), "For parameters of TestRecords the scope must be a TestRecord" | |
| response = delete_test_record_test_parameter.sync_detailed( | |
| self._project_id, | |
| items[0].scope.test_run_id, | |
| items[0].scope.work_item_project_id, | |
| items[0].scope.work_item_id, | |
| str(items[0].scope.iteration), | |
| items[0].name, | |
| assert len(items) == 1 | |
| test_parameter = items[0] | |
| assert isinstance( | |
| test_parameter.scope, dm.TestRecord | |
| ), "For parameters of TestRecords the scope must be a TestRecord" | |
| response = delete_test_record_test_parameter.sync_detailed( | |
| self._project_id, | |
| test_parameter.scope.test_run_id, | |
| test_parameter.scope.work_item_project_id, | |
| test_parameter.scope.work_item_id, | |
| str(test_parameter.scope.iteration), | |
| test_parameter.name, |
Better readability.
ewuerger
requested changes
May 23, 2025
Comment on lines
192
to
193
| def _delete(self, items: list[dm.TestParameter]): | ||
| assert len(items) == 1 |
Collaborator
There was a problem hiding this comment.
Suggested change
| def _delete(self, items: list[dm.TestParameter]): | |
| assert len(items) == 1 | |
| def _delete(self, items: list[dm.TestParameter]): | |
| """Delete a single test parameter.""" | |
| assert len(items) == 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.