feat: Add Documents #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahbar
force-pushed
the
add-documents
branch
2 times, most recently
from
716ee65 to
2622e9c
Compare
micha91
requested changes
Dec 13, 2023
Collaborator
micha91
left a comment
micha91
left a comment
There was a problem hiding this comment.
Requested some minor changes which could also be used in other parts of this project in the future
Overall a really good first PR 👍
dahbar
force-pushed
the
add-documents
branch
from
30b161a to
3708e32
Compare
micha91
requested changes
Dec 19, 2023
Collaborator
micha91
left a comment
micha91
left a comment
There was a problem hiding this comment.
Just some minor tweaks in _handle_home_page_content and we are good to go
ewuerger
requested changes
Jan 2, 2024
Collaborator
ewuerger
left a comment
ewuerger
left a comment
There was a problem hiding this comment.
After these changes green light from me.
micha91
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_document()