CB-5867 show objects description #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyteleshev
approved these changes
Jan 6, 2025
SychevAndrey
approved these changes
Jan 9, 2025
sergeyteleshev
approved these changes
Jan 9, 2025
| @@ -52,6 +54,7 @@ export const NavigationNodeControl: NavTreeControlComponent = observer( | |||
| const styles = useS(style); | |||
| const mouseContextMenu = useMouseContextMenu(); | |||
| const treeNodeContext = useContext(TreeNodeContext); | |||
| const elementsTreeContext = useContext(ElementsTreeContext); | |||
There was a problem hiding this comment.
may be useMemo would be enough here for treeNodeContext.selected and elementsTreeContext?.tree.settings?.objectsDescription?
SychevAndrey
approved these changes
Jan 10, 2025
|
|
||
| import type { IElementsTreeCustomNodeInfo } from './useElementsTree.js'; | ||
|
|
||
| export function transformDescriptionNodeInfo(navNodeInfoResource: NavNodeInfoResource): IElementsTreeCustomNodeInfo { |
There was a problem hiding this comment.
I know this is not a part of your task, but this type name is misleading. I don't anticipate a function from type named like that. Maybe just add Fn suffix to show that this is function. Or smth like IElementsTreeCustomNodeInfoModifier
Wroud
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably want to wrap context in useObjectRef or pass this setting as prop to avoid perfomance issues because of the using useContext