Skip to content

Revert #381 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Revert #381 #2

merged 1 commit into from
Feb 23, 2023

Conversation

dbeatty10
Copy link
Owner

Prior to datafold#381, there were 3 different output formats:

  • default
  • --stats
  • --json

Afterwards, there was a new 4th format, and it only applied to --dbt mode.

Two things I'd like:

  1. As a user of the --dbt mode, I'd prefer that I can use the same output format options as the regular data-diff command.
  2. If a 4th output option is added, I'd like to be able to use a command-line flag to opt-in to it with a --spruce flag (or some other name for the new format).

To get those two things, I'll do the following:

  1. Revert the new spruced-up output in #381 (which can be added back later if desired)
  2. Make all 3 of the pre-existing format options available when using --dbt

@dbeatty10 dbeatty10 marked this pull request as ready for review February 23, 2023 23:53
@dbeatty10 dbeatty10 merged commit c4a8860 into master Feb 23, 2023
@dbeatty10 dbeatty10 mentioned this pull request Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant