Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python2.7. #1153

Merged
merged 7 commits into from
Mar 10, 2020
Merged

Deprecate Python2.7. #1153

merged 7 commits into from
Mar 10, 2020

Conversation

laixintao
Copy link
Member

@laixintao laixintao commented Mar 9, 2020

So we can use latest version of prompt-toolit.
Relate: #1149

Checklist

  • I've added this contribution to the changelog.rst.
  • I've added my name to the AUTHORS file (or it's already there).
  • I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

Copy link
Contributor

@j-bennet j-bennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also want to remove Python 2 and 2.7 from setup.py.

@laixintao
Copy link
Member Author

Updated, sorry I forgot

@laixintao laixintao requested a review from j-bennet March 10, 2020 02:12
@codecov-io
Copy link

Codecov Report

Merging #1153 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1153      +/-   ##
==========================================
- Coverage   84.27%   84.07%   -0.21%     
==========================================
  Files          22       22              
  Lines        2531     2530       -1     
==========================================
- Hits         2133     2127       -6     
- Misses        398      403       +5
Impacted Files Coverage Δ
pgcli/main.py 76.72% <ø> (-0.18%) ⬇️
pgcli/encodingutils.py 83.33% <0%> (-16.67%) ⬇️
pgcli/packages/sqlcompletion.py 97.35% <0%> (-0.34%) ⬇️
pgcli/pgexecute.py 82.28% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91263c3...ba39bcb. Read the comment docs.

Copy link
Contributor

@j-bennet j-bennet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@j-bennet j-bennet merged commit fd77549 into dbcli:master Mar 10, 2020
@j-bennet
Copy link
Contributor

Merged! Thanks a lot! 🍫

@laixintao
Copy link
Member Author

@j-bennet I am going to open a PR to drop 3.5 as well, and working on #1149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants