Cleaner shutdown for completion_refresher - #2131
Merged
Merged
Conversation
we were definitely missing
try:
self.completion_refresher.stop()
except Exception:
pass
in close() in mycli/client.py, and can also do a bit more to ensure
safety for the completion refresher, such as preventing completion
callbacks after shutdown starts.
rolandwalker
force-pushed
the
RW/completion-refresher-stop
branch
from
August 12, 2026 09:54
160155d to
93a2bd8
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were definitely missing
in
close()inmycli/client.py, and can also do a bit more to ensure safety for the completion refresher, such as preventing completion callbacks after shutdown starts.Fixes #2130.
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).