Skip to content

Add binary_as_text configuration option#1512

Open
rolandwalker wants to merge 1 commit intomainfrom
RW/add-binary-as-text-config-option
Open

Add binary_as_text configuration option#1512
rolandwalker wants to merge 1 commit intomainfrom
RW/add-binary-as-text-config-option

Conversation

@rolandwalker
Copy link
Contributor

Description

This is the rough equivalent of the vendor --skip-binary-as-text CLI option, which has the effect of reversing

when set.

I'm still not sure how to write tests for non-default myclirc options, though there may have been a recent example.

Fixes #1511.

Checklist

  • I added this contribution to the changelog.md file.
  • I added my name to the AUTHORS file (or it's already there).
  • To lint and format the code, I ran
    uv run ruff check && uv run ruff format && uv run mypy --install-types .

@rolandwalker rolandwalker force-pushed the RW/add-binary-as-text-config-option branch from e0676ab to fd133c2 Compare February 5, 2026 09:36
@rolandwalker rolandwalker changed the title Add binary_as_text configuration option Add binary_as_text configuration option Feb 5, 2026
@rolandwalker rolandwalker self-assigned this Feb 5, 2026
This is the rough equivalent of the vendor --skip-binary-as-text CLI
option, which has the effect of reversing

 * #1483

when set.
@rolandwalker rolandwalker force-pushed the RW/add-binary-as-text-config-option branch from fd133c2 to 8dde329 Compare February 5, 2026 09:57
@rolandwalker
Copy link
Contributor Author

Maybe the configuration option should be non-boolean, like

binary_display = hex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[possible degradation] UTF-8 string is now printed in 0x hex form in some cases.

1 participant