Update with reviewer feedback

dbalde · Jul 13, 2020 · c4a92b0 · c4a92b0
1 parent cc47423
commit c4a92b0
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/packages/cache/src/internal/downloadUtils.ts b/packages/cache/src/internal/downloadUtils.ts
@@ -120,12 +120,12 @@ export class DownloadProgress {
   }
 
   /**
-   * Callback used to update the progress.
-   *
-   * @param progress the progress event
+   * Returns a function used to handle TransferProgressEvents.
    */
-  onProgressCallback(progress: TransferProgressEvent): void {
-    this.setReceivedBytes(progress.loadedBytes)
+  onProgress(): (progress: TransferProgressEvent) => void {
+    return (progress: TransferProgressEvent) => {
+      this.setReceivedBytes(progress.loadedBytes)
+    }
   }
 
   /**
@@ -261,9 +261,7 @@ export async function downloadCacheStorageSDK(
           segmentSize,
           {
             concurrency: options.downloadConcurrency,
-            onProgress: downloadProgress.onProgressCallback.bind(
-              downloadProgress
-            )
+            onProgress: downloadProgress.onProgress()
           }
         )