Skip to content

fix: lint-stages issue with generate icon fonts #1832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2023
Merged

fix: lint-stages issue with generate icon fonts #1832

merged 3 commits into from
Nov 16, 2023

Conversation

nmerget
Copy link
Collaborator

@nmerget nmerget commented Nov 15, 2023 •
edited by mfranzke
Loading

Proposed changes

Resolves https://github.com/db-ui/mono/issues/1827

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/fix-lint-staged-generate-icons

@nmerget nmerget linked an issue Nov 15, 2023 that may be closed by this pull request
lint staged update:icon-fonts script leads to problems #1827
Closed
7 tasks
@nmerget nmerget enabled auto-merge (squash) November 15, 2023 07:32
mfranzke
mfranzke reviewed Nov 15, 2023
View reviewed changes
@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Nov 15, 2023
@mfranzke mfranzke added the 🐛bug Something isn't working label Nov 15, 2023
@nmerget nmerget merged commit 2403a5b into main Nov 16, 2023
@nmerget nmerget deleted the fix-lint-staged-generate-icons branch November 16, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch

Assignees

@nmerget nmerget

Labels
🐛bug Something isn't working
Projects
None yet
Milestone
Open Beta Release (0.1.0)
Development

Successfully merging this pull request may close these issues.

lint staged update:icon-fonts script leads to problems
2 participants
@nmerget @mfranzke