Skip to content

refactor: updated icons #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 22, 2023
Merged

refactor: updated icons #1824

merged 16 commits into from
Nov 22, 2023

Conversation

mfranzke
Copy link
Collaborator

Proposed changes

Resolves https://github.com/db-ui/mono/issues/1822

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added this to the Guidelines 3.0 Beta milestone Nov 14, 2023
@mfranzke mfranzke self-assigned this Nov 14, 2023
@mfranzke mfranzke linked an issue Nov 14, 2023 that may be closed by this pull request
Icon Update #1822
Closed
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/1822-icon-update

@mfranzke mfranzke changed the title refactor: updated illustrative icons refactor: updated icons Nov 14, 2023
@mfranzke mfranzke mentioned this pull request Nov 14, 2023
Closed
7 tasks
@mfranzke mfranzke marked this pull request as ready for review November 14, 2023 13:57
@mfranzke mfranzke enabled auto-merge November 15, 2023 23:07
@nmerget
Copy link
Collaborator

nmerget commented Nov 16, 2023

https://db-ui.github.io/mono/review/1822-icon-update/foundations/icons/overview -> navigation_u_turn isn't working

nmerget
nmerget reviewed Nov 16, 2023
View reviewed changes
@mfranzke mfranzke mentioned this pull request Nov 17, 2023
Closed
@mfranzke mfranzke requested a review from nmerget November 17, 2023 07:34
@nmerget nmerget added 🍄🆙improvement New feature or request and removed improvement labels Nov 17, 2023
@mfranzke
Copy link
Collaborator Author

https://db-ui.github.io/mono/review/1822-icon-update/foundations/icons/overview -> navigation_u_turn isn't working

that's not good …

@mfranzke
Copy link
Collaborator Author

https://db-ui.github.io/mono/review/1822-icon-update/foundations/icons/overview -> navigation_u_turn isn't working

fixed

@mfranzke mfranzke merged commit 455d1d4 into main Nov 22, 2023
@mfranzke mfranzke deleted the 1822-icon-update branch November 22, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch

Assignees

@mfranzke mfranzke

Labels
🍄🆙improvement New feature or request
Projects
None yet
Milestone
Open Beta Release (0.1.0)
Development

Successfully merging this pull request may close these issues.

Icon Update
2 participants
@mfranzke @nmerget