Skip to content

refactor: radio and checkbox simplification and correction #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented May 5, 2023

  • checkbox: Simplified code
  • radio: The background-color change on :hover isn't supposed to happen on :checked and :disabled states

@mfranzke mfranzke added bug Something isn't working improvement labels May 5, 2023
@mfranzke mfranzke added this to the Release 2.x milestone May 5, 2023
@mfranzke mfranzke self-assigned this May 5, 2023
@mfranzke mfranzke requested review from nmerget, dkolba and annsch as code owners May 5, 2023 08:13
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

@mfranzke mfranzke enabled auto-merge (squash) May 5, 2023 08:15
@mfranzke mfranzke merged commit c52a643 into main May 9, 2023
@mfranzke mfranzke deleted the refactor-radio-checkbox-simplification-and-correction branch May 9, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement patterns
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants