Skip to content

fix(button): active disabled state visualization #443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 8, 2023
Merged

fix(button): active disabled state visualization #443

merged 2 commits into from
May 8, 2023

Conversation

mfranzke
Copy link
Member

@mfranzke mfranzke commented May 4, 2023 •
edited
Loading

Resolves #440

The :active pseudo-selector even also needs to get set in relation to :disabled state of the buttons.

@mfranzke mfranzke added the bug Something isn't working label May 4, 2023
@mfranzke mfranzke added this to the Release 2.x milestone May 4, 2023
@mfranzke mfranzke self-assigned this May 4, 2023
@mfranzke mfranzke requested review from nmerget and dkolba as code owners May 4, 2023 10:00
@mfranzke mfranzke linked an issue May 4, 2023 that may be closed by this pull request
Disabled button has click effect #440
Closed
@mfranzke mfranzke requested a review from annsch as a code owner May 4, 2023 10:00
@mfranzke mfranzke enabled auto-merge (squash) May 4, 2023 10:00
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

🔭🐙🐈 Test this branch here: https://db-ui.github.io/core/review/440-disabled-button-has-click-effect

@mfranzke mfranzke changed the title fix(button): active disabled state visualization #440 fix(button): active disabled state visualization May 4, 2023
@mfranzke mfranzke requested review from dkolba, annsch and nmerget and removed request for dkolba, annsch and nmerget May 5, 2023 07:54
@mfranzke mfranzke merged commit 665c6e4 into main May 8, 2023
@mfranzke mfranzke deleted the 440-disabled-button-has-click-effect branch May 8, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget nmerget approved these changes

@dkolba dkolba Awaiting requested review from dkolba dkolba is a code owner

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees

@mfranzke mfranzke

Labels
bug Something isn't working patterns
Projects
None yet
Milestone
Guidelines v2
Development

Successfully merging this pull request may close these issues.

Disabled button has click effect
2 participants
@mfranzke @nmerget